Skip to content

Conversation

@gijsk
Copy link
Contributor

@gijsk gijsk commented Aug 3, 2022

Noticed that WONTFIX bugs don't get automatically closed on JIRA. I think this should fix that?

@gijsk gijsk requested a review from a team as a code owner August 3, 2022 15:06
@gijsk
Copy link
Contributor Author

gijsk commented Aug 3, 2022

Might be nice to also update the "resolution field" on JIRA? But I don't know how to do that.

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to also update the "resolution field" on JIRA? But I don't know how to do that.

Apparently, the .set_issue_status() method also accepts fields. But it would probably deserve a dedicated issue/PR.

@leplatrem leplatrem added the configuration Changes to JBI action configuration label Aug 3, 2022
@gijsk
Copy link
Contributor Author

gijsk commented Aug 3, 2022

Might be nice to also update the "resolution field" on JIRA? But I don't know how to do that.

Apparently, the .set_issue_status() method also accepts fields. But it would probably deserve a dedicated issue/PR.

Separate PR sounds good. I'm guessing that means more changes than just the yaml file? Or do I "just" need a separate mapping of sorts? Sorry, I'm still very not-familiar with this repository! 😅

@leplatrem
Copy link
Contributor

Separate PR sounds good. I'm guessing that means more changes than just the yaml file?

Unfortunately, you guess right :) You would need to modify the action code (jbi/actions/default_with_assignee_and_status.py), add some unit tests, and test it on STAGE. You can open an issue for now, and if you feel like doing all this, assign it to you ;)

@gijsk
Copy link
Contributor Author

gijsk commented Aug 10, 2022

OK, I filed #200 . Can we land this in the meantime? :-)

@grahamalama
Copy link
Contributor

@gijsk yep! Merging now.

@grahamalama grahamalama merged commit 39c41e3 into mozilla:main Aug 10, 2022
@grahamalama
Copy link
Contributor

grahamalama commented Aug 10, 2022

@gijsk let us know when you have time to verify these changes in staging, then we can slate it for an upcoming release

@gijsk
Copy link
Contributor Author

gijsk commented Aug 11, 2022

@grahamalama I'm sorry but I don't know any of the staging details (location of bmo/jira instances, credentials, etc.) so I don't know how to do that...

@leplatrem leplatrem mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration Changes to JBI action configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants