Skip to content

Update Web Share and Web Share Target positions #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jul 11, 2019

closes #27
closes #176

@marcoscaceres marcoscaceres requested a review from dbaron July 11, 2019 04:29
@marcoscaceres marcoscaceres changed the title Update Web Share position to 'worth prototyping' Update Web Share and target positions Oct 3, 2019
@marcoscaceres marcoscaceres changed the title Update Web Share and target positions Update Web Share and Web Share Target positions Oct 3, 2019
@marcoscaceres marcoscaceres mentioned this pull request Oct 3, 2019
@marcoscaceres
Copy link
Contributor Author

@dbaron, ping. Web Share itself is ready to land behind a pref:
https://phabricator.services.mozilla.com/D44598

@dbaron
Copy link
Contributor

dbaron commented Oct 21, 2019

Sorry for the delay @marcoscaceres -- I'm back from vacation now.

One concern about this PR is that it updates the position on Web Share to important without any discussion of that change in #27. Could you discuss that particular change there?

It might also be worth writing a little bit of text in the mozPositionDetail explaining why these specifications are worth prototyping or important.

@marcoscaceres
Copy link
Contributor Author

I'll defer to the product owners to provide positions, as they are in charge of adding these to Firefox.

@marcoscaceres
Copy link
Contributor Author

One concern about this PR is that it updates the position on Web Share to important without any discussion of that change in #27. Could you discuss that particular change there?

@dbaron, I added some thoughts of why I think it's important - hopefully other folks will chime in. The feature is already in Fenix, so hopefully we can reach a position before it ships. I imagine the Fenix team will send an "intent to ship" at some point.

#27 (comment)

@annevk annevk deleted the webshare branch March 8, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Share API Web Share Target
2 participants