Skip to content

Examples: Improve webgpu_compute_water #31011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 27, 2025

Related issue: #30985 (comment)

Description

Improved water physics and some other revisions.

Temporary live link
https://raw.githack.com/mrdoob/three.js/dev/examples/webgpu_compute_water.html

Previous
#30985 (comment)

@sunag sunag added this to the r177 milestone Apr 27, 2025
@sunag sunag changed the title Example: Improve webgpu_compute_water example Example: Improve webgpu_compute_water Apr 27, 2025
@sunag sunag changed the title Example: Improve webgpu_compute_water Examples: Improve webgpu_compute_water Apr 27, 2025
@sunag sunag marked this pull request as ready for review April 27, 2025 18:15
@WestLangley
Copy link
Collaborator

macOS Sequoia 15.4.1 Safari 18.4 Apple M1 . It looks like a feed-back loop in the amplitude of the waves. Same artifacts prior to this PR.

Screenshot 2025-04-27 at 2 58 48 PM

@Spiri0
Copy link
Contributor

Spiri0 commented Apr 27, 2025

Interesting, mrdoob reported an issue with my repo that might be related to this.

Spiri0/Threejs-WebGPU-IFFT-Ocean#8

Since I don't have a Mac, I have a hard time with Mac-specific bugs. I'll update to r177 when it's out and I'll be curious.
My Ocean's geometry system is pretty outdated anyway. But I don't want to publish the much better solution yet, as I hope to be able to impress companies with it.

@sunag sunag merged commit 8a8be91 into mrdoob:dev Apr 28, 2025
11 checks passed
@sunag sunag deleted the dev-water-rev1 branch April 28, 2025 03:00
@sunag sunag restored the dev-water-rev1 branch April 28, 2025 03:00
@sunag sunag deleted the dev-water-rev1 branch April 28, 2025 03:00
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants