Skip to content

Add FXAAPass class #31044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025
Merged

Add FXAAPass class #31044

merged 5 commits into from
May 5, 2025

Conversation

neilrackett
Copy link
Contributor

@neilrackett neilrackett commented May 4, 2025

The Three.js FXAA implementation is fantastic, but the WebGL pass has always felt unnecessarily cumbersome and more complicated to use than it needs to be.

This pull request simplifies the creation and use of an FXAA pass by creating a new FXAAPass class that works in the same way as SMAAPass: rather than having to pass FXAAShader as a parameter of the ShaderPass class and manually manage the size of the pass, you simply create a single class instance which is automatically updated by the EffectComposer calling its setSize method.

@neilrackett neilrackett changed the title Fxaapass class Add FXAAPass class May 4, 2025
@Mugen87 Mugen87 added this to the r177 milestone May 5, 2025
@Mugen87 Mugen87 merged commit 984ca4a into mrdoob:dev May 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants