Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Three.js FXAA implementation is fantastic, but the WebGL pass has always felt unnecessarily cumbersome and more complicated to use than it needs to be.
This pull request simplifies the creation and use of an FXAA pass by creating a new
FXAAPass
class that works in the same way asSMAAPass
: rather than having to passFXAAShader
as a parameter of theShaderPass
class and manually manage the size of the pass, you simply create a single class instance which is automatically updated by theEffectComposer
calling itssetSize
method.