Skip to content

Conversation

frizzy
Copy link
Contributor

@frizzy frizzy commented Nov 3, 2016

No description provided.

@mysensors-jenkins
Copy link

Git commit message(s) not good enough. I have mailed the details to the PR author.

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad
Copy link
Member

Jenkins, build examples please.

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/Verifiers/job/MySensorsArduinoPR/585/

strncpy(topicTrimmed, &topic[strlen(MY_MQTT_SUBSCRIBE_TOPIC_PREFIX) + 1], topiclen);
topicTrimmed[topiclen] = (char)0;

for (str = strtok_r(topicTrimmed, "/", &p); str && i <= 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to copy topic into the new buffer topicTrimmed?

I think you just could add to the topic pointer this:

for (str = strtok_r(topic + strlen(MY_MQTT_SUBSCRIBE_TOPIC_PREFIX), "/", &p);

Maybe you could test this in your environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! That looks way more elegant. I'll try that on my environment today. Thanks.

@mysensors-jenkins
Copy link

Git commit message(s) look good!

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad
Copy link
Member

Thanks @frizzy!

@henrikekblad henrikekblad merged commit e77f3c0 into mysensors:development Nov 4, 2016
@tekka007 tekka007 modified the milestone: 2.1.0 Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants