Skip to content

0.23.0 #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 14, 2019
Merged

0.23.0 #492

merged 8 commits into from
Jan 14, 2019

Conversation

Ilaiwi
Copy link
Collaborator

@Ilaiwi Ilaiwi commented Jan 14, 2019

Issue Number

#426
#384
#484
#478

Overview of PR

improve unit tests coverage #426 - @Ilaiwi
stack items by group #384 - @acemac
fix bug where canMove prop gets ignored #484 - @acemac + @Ilaiwi
fix sidebar re-render when groupHeights do not change #478 - @SDupZ

acemac and others added 8 commits December 7, 2018 15:08
**Issue Number**

#397 replacement because I'm terrible at using git

**Overview of PR**

Removing the API updates that were accidentally merged in to #397 turned out to be an ordeal. This PR should be cleaner.

_Don't forget to update the CHANGELOG.md file with any changes that are in this PR_
* Can stack items by group

* comments

* Bug fix to stop including items that cannot render on timeline

* Changes from stack branch

* safety check

* ye olde safety check

* manually adding stuff from stack branch

* Fixes based off requested changes

* snapshots

* add tests for stackgroup and no stackgroup

* refactor calculate dimensions + add tests cases for stack items

* [WIP] refacor calculate dimentions

* test getItemWithInteractions

* test getItemDimensions

* add canvasTimeStart to state

* solve NaN issue in snapshot

* getCanvasWidth

* refactor stackItems to stackTimelineItems

* add one more item and group

* WIP stackAll

* better items fixture

* format

* stack groups

* fix bug with stackAll

* convert moment to milliseconds
**Issue Number**
#484 

**Overview of PR**

Checks canMove on initial interact mount.

_Don't forget to update the CHANGELOG.md file with any changes that are in this PR_
@Ilaiwi Ilaiwi changed the title Develop 0.23.0 Jan 14, 2019
@Ilaiwi Ilaiwi merged commit 74672c2 into master Jan 14, 2019
@oskari
Copy link

oskari commented Jan 28, 2019

There's no 0.23.0 release on github, only in npm.

@Ilaiwi
Copy link
Collaborator Author

Ilaiwi commented Jan 28, 2019

@oskari ops I will add it to github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants