[WIP] XLabs support #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancelled the pull request. When looking at the XFormsApplicationDroid code it seems like a better idea to create a class inheriting from AppCompatFormsActivity and implementing features from XFormsApplicationDroid manually (in other words, the opposite of this pull request) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening a new pull request to see if this is of any interest for you; to enable all features of XLabs in Xamarin.Forms the MainActivity class in Android has to inherit from XFormsApplicationDroid.
This branch is an effort to make an Xlabs-enabled AppCompatFormsActivity.
Some refactoring may be required to improve code sharing between the classes.