feat(kv,jetstream)Add support for per-message TTLs in KV and JetStream #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced `markerTTL` and per-message TTL options, allowing fine-grained control over retention policies. Updated KV methods, types, and tests to support these features, ensuring compatibility with streams enabling `allow_msg_ttl`. Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
…t server seems to not honor the request, but doesn't return an error. Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
…header Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
…KvJsMsgEntryImpl Signed-off-by: Alberto Ricart <[email protected]>
jkriss
reviewed
Jul 16, 2025
| h.set(PubHeaders.ExpectedLastSubjectSequenceHdr, `${opts.previousSeq}`); | ||
| } | ||
| if (opts.ttl) { | ||
| const h = o.headers || headers(); |
There was a problem hiding this comment.
If o.headers isn't set, the newly created headers won't be attached to o on line 626, right?
|
Can you do something so that it become available in nats.js package? It merged a couple of months ago, but still impossible to use it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
markerTTLand per-message TTL options, allowing fine-grained control over retention policies. Updated KV methods, types, and tests to support these features, ensuring compatibility with streams enablingallow_msg_ttl.