Skip to content

Toolbar add page origin private #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2020
Merged

Toolbar add page origin private #7

merged 3 commits into from
Nov 26, 2020

Conversation

recrwplay
Copy link
Collaborator

In a playbook or asciidoc source file set the attribute page-origin-private: true to prevent the 'Edit this page' link from being included in the output.

@ggrossetie
Copy link
Contributor

Could you please add this condition in edit-this-page-link.hbs? This "component" is included in other places and I think we want a consistent behavior.

@recrwplay
Copy link
Collaborator Author

Moved into edit-this-page-link.hbs as requested

ggrossetie
ggrossetie approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ggrossetie
Copy link
Contributor

Moved into edit-this-page-link.hbs as requested

Thanks, all good on my side!
I will wait a bit before merging to give @adam-cowley time to review.

@recrwplay
Copy link
Collaborator Author

Thanks @Mogztter

@adam-cowley
Copy link
Collaborator

Looks good to me...

@recrwplay
Copy link
Collaborator Author

Thanks @adam-cowley

@ggrossetie ggrossetie merged commit 33f509d into neo4j-documentation:master Nov 26, 2020
@ggrossetie
Copy link
Contributor

And merged 👌

@recrwplay recrwplay deleted the toolbar-add-page-origin-private branch November 27, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@recrwplay @ggrossetie @adam-cowley