Skip to content

Introduce connectionLivenessCheckTimeout configuration #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 4, 2023
Merged

Introduce connectionLivenessCheckTimeout configuration #1162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
01c9f75
Introduce `connectionLivenessCheckTimeout` configuration
bigmontz Nov 23, 2023
34e01fd
Start work in the liveness check provider
bigmontz Nov 23, 2023
bf3d31a
Add idleTimestamp to Connection and implement tests for LivenessCheck…
bigmontz Nov 23, 2023
db2ce2d
Small refactory
bigmontz Nov 23, 2023
47eb65e
Add LivenessCheckProvider to PooledConnectionProvider
bigmontz Nov 24, 2023
a07c86f
Add testkit backend bits
bigmontz Nov 24, 2023
c17cba6
Add tests for validateOnAcquire
bigmontz Nov 24, 2023
54d5d9c
Update release tests for checking the idleTimestamp
bigmontz Nov 24, 2023
718b844
Validate connection liveness check timeout
bigmontz Nov 24, 2023
b704559
Validate connection liveness check timeout
bigmontz Nov 24, 2023
745cb3c
Skip tests which needs unification
bigmontz Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update release tests for checking the idleTimestamp
  • Loading branch information
@bigmontz
bigmontz committed Nov 27, 2023
commit 54d5d9cf81ff4d981a89edb3dc2c043a433cbc1e
21 changes: 14 additions & 7 deletions packages/bolt-connection/test/connection-provider/connection-provider-direct.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,16 +282,23 @@ describe('constructor', () => {
})

it('should register the release function into the connection', async () => {
const { create } = setup()
const releaseResult = { property: 'some property' }
const release = jest.fn(() => releaseResult)
jest.useFakeTimers()
try {
const { create } = setup()
const releaseResult = { property: 'some property' }
const release = jest.fn(() => releaseResult)

const connection = await create({}, server0, release)
const connection = await create({}, server0, release)
connection.idleTimestamp = -1234

const released = connection.release()
const released = connection.release()

expect(released).toBe(releaseResult)
expect(release).toHaveBeenCalledWith(server0, connection)
expect(released).toBe(releaseResult)
expect(release).toHaveBeenCalledWith(server0, connection)
expect(connection.idleTimestamp).toBeCloseTo(Date.now())
} finally {
jest.useRealTimers()
}
})

it.each([
Expand Down
21 changes: 14 additions & 7 deletions packages/bolt-connection/test/connection-provider/connection-provider-routing.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3186,16 +3186,23 @@ describe.each([
})

it('should register the release function into the connection', async () => {
const { create } = setup()
const releaseResult = { property: 'some property' }
const release = jest.fn(() => releaseResult)
jest.useFakeTimers()
try {
const { create } = setup()
const releaseResult = { property: 'some property' }
const release = jest.fn(() => releaseResult)

const connection = await create({}, server0, release)
const connection = await create({}, server0, release)
connection.idleTimestamp = -1234

const released = connection.release()
const released = connection.release()

expect(released).toBe(releaseResult)
expect(release).toHaveBeenCalledWith(server0, connection)
expect(released).toBe(releaseResult)
expect(release).toHaveBeenCalledWith(server0, connection)
expect(connection.idleTimestamp).toBeCloseTo(Date.now())
} finally {
jest.useRealTimers()
}
})

it.each([
Expand Down