Skip to content

Add version to API #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Add version to API #18

merged 1 commit into from
Dec 2, 2015

Conversation

pontusmelke
Copy link
Contributor

Moved neo4j to neo4j.v1 in order to facilitate API migrations in
future versions.

@jakewins
Copy link
Contributor

IMO, we should keep the neo4j root namespace, and introduce a v1 namespace inside it instead:

require('neo4j.v1');
import 'neo4j.v1';

@jakewins
Copy link
Contributor

This should be possible by adding a v1 folder inside the src dir, and exposing that v1 folder though the neo4j.js file exports.

Now we do `var neo4j = require('neo4j').v1;`
@pontusmelke
Copy link
Contributor Author

@jakewins any better, I think it is require('neo4j').v1; but otherwise I think it is what you meant?

@jakewins
Copy link
Contributor

jakewins commented Dec 2, 2015

+1

jakewins added a commit that referenced this pull request Dec 2, 2015
@jakewins jakewins merged commit a050859 into neo4j:master Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants