BUGFIX: Loosely compare values in isOptionSelected #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this method compares values "type unsafe", because due to the nature of web requests numbers and strings cannot really be distinguished. This leads to false negatives if option values are given as numbers but incoming data is a string. Fixes neos#26
|
wondering if its breaking? if not 👍 |
Who knows… 😎 |
|
I hope @GuangHa can test this in a real-world project… |
fcool
approved these changes
Dec 23, 2022
daniellienert
approved these changes
Dec 24, 2022
|
@kdambekalns Uh just realized, target on master was probably not intended? |
@daniellienert There aren't any other release branches… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this method compares values "type unsafe", because due to the nature of web requests numbers and strings cannot really be distinguished. This leads to false negatives if option values are given as numbers but incoming data is a string.
Fixes #26