Skip to content

FEATURE: Compatibility with neos/flow v9.0 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

c4ll-m3-j4ck
Copy link
Contributor

With version 9.0, previously deprecated fusion prototypes have been removed. This PR replaces the removed prototypes with the suggested replacements.

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 by 👀

@dlubitz dlubitz mentioned this pull request Oct 7, 2024
@dlubitz
Copy link
Contributor

dlubitz commented Oct 7, 2024

I moved two changes from the duplicate #30 PR to complete this.

@dlubitz
Copy link
Contributor

dlubitz commented Oct 7, 2024

Before we merge this, I wonder if we need to raise the version constraint here for neos/form? Or add a version constraint for Neos 9?

@dlubitz
Copy link
Contributor

dlubitz commented Oct 7, 2024

Actually it should have a dependency to fusion, but yeah, not part of this PR.

@dlubitz dlubitz merged commit 0f97d15 into neos:master Oct 7, 2024
@kdambekalns
Copy link
Member

kdambekalns commented Oct 7, 2024

Before we merge this, I wonder if we need to raise the version constraint here for neos/form? Or add a version constraint for Neos 9?

The "new" prototypes used are nothing specific to Neos 9, and the (transitive) dependency chain looks good to me…

@kdambekalns
Copy link
Member

neos/form-fusionrenderer needs neos/form needs neos/flow – but no neos/fusion, right. Good catch!

@dlubitz
Copy link
Contributor

dlubitz commented Oct 7, 2024

Thank you @c4ll-m3-j4ck for your contribution. I created a new release with this change
https://github.com/neos/form-fusionrenderer/releases/tag/2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants