fix: argument in "vim.foo({bar})" #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's still a parse error (but not wrong highlighting) in
(but not in |
Looks like the |
|
Ah, I had assumed that the (I have hesitated to touch upstream docs so far, but if it's open season now...) |
|
This definitely improves things, but also causes a few errors. Will see if those can be avoided with some tweaks. |
justinmk
commented
Jun 25, 2023
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jun 25, 2023
Prepare for neovim/tree-sitter-vimdoc#108 which improves `{arg}` highlighting in many common cases: vim.foo({bar}) vim.foo( {bar}) nvim_foo({bar}) nvim_foo({bar},{baz}) nvim_foo({bar}, {baz}) foo[{buf}] The tradeoff is that things like `"[{"` are flagged as parse errors. We could avoid if we drop support for `foo[{buf}]`, but that is rather common (see `builtin.txt`).
Problem:
In "vim.foo({bar})", {bar} is not recognized as (argument).
Solution:
Add more special-cases for plain (word).
Closes #102
- Dropping ")" and "]" special-cases avoids 10 (out of ~30) new errors in a full
`gen_help_html.validate()` run.
- The /\w+\(/ special is no longer needed since "(" was added.
- Other cases appear redundant, they don't affect test results nor
`gen_help_html.validate()` results.
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jun 26, 2023
Prepare for neovim/tree-sitter-vimdoc#108 which improves `{arg}` highlighting in many common cases: vim.foo({bar}) vim.foo( {bar}) nvim_foo({bar}) nvim_foo({bar},{baz}) nvim_foo({bar}, {baz}) foo[{buf}] The tradeoff is that things like `"[{"` are flagged as parse errors. We could avoid if we drop support for `foo[{buf}]`, but that is rather common (see `builtin.txt`).
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jun 26, 2023
Prepare for neovim/tree-sitter-vimdoc#108 which improves `{arg}` highlighting in many common cases: vim.foo({bar}) vim.foo( {bar}) nvim_foo({bar}) nvim_foo({bar},{baz}) nvim_foo({bar}, {baz}) foo[{buf}] The tradeoff is that things like `"[{"` are flagged as parse errors. We could avoid if we drop support for `foo[{buf}]`, but that is rather common (see `builtin.txt`).
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jun 26, 2023
Prepare for neovim/tree-sitter-vimdoc#108 which improves `{arg}` highlighting in many common cases: vim.foo({bar}) vim.foo( {bar}) nvim_foo({bar}) nvim_foo({bar},{baz}) nvim_foo({bar}, {baz}) foo[{buf}] The tradeoff is that things like `"[{"` are flagged as parse errors. We could avoid if we drop support for `foo[{buf}]`, but that is rather common (see `builtin.txt`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Continues #103 )
Problem:
In "vim.foo({bar})", {bar} is not recognized as (argument).
Solution:
Add more special-cases for plain (word).
Closes #102
Notes
(url)case:tree-sitter-vimdoc/corpus/url.txt
Line 42 in 755b801