Add multi-processing support for cache_image. Fixed the issue of insufficient precision leading to a completely black image when converting from RGBA to RGB. #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d SplatfactoModel
brentyi
reviewed
Feb 2, 2024
brentyi
reviewed
Feb 2, 2024
Collaborator
brentyi
left a comment
brentyi
left a comment
There was a problem hiding this comment.
Looks reasonable to me! Just left two comments 🙂
brentyi
reviewed
Feb 2, 2024
Contributor
Author
Hi! I have updated the code based on the comments. Thank you for your suggestions！ |
KevinXu02
changed the title
Contributor
Author
|
Also fixed the issue of insufficient precision leading to a completely black image when converting from RGBA to RGB. |
jb-ye
reviewed
Feb 5, 2024
| self._dataparser_outputs.alpha_color <= 1 | ||
| ).all(), "alpha color given is out of range between [0, 1]." | ||
| image = image[:, :, :3] * image[:, :, -1:] / 255.0 + 255.0 * self._dataparser_outputs.alpha_color * ( | ||
| image = image[:, :, :3] * (image[:, :, -1:] / 255.0) + 255.0 * self._dataparser_outputs.alpha_color * ( |
Collaborator
There was a problem hiding this comment.
Thanks for catching this bug.
Collaborator
|
lgtm |
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
…fficient precision leading to a completely black image when converting from RGBA to RGB. (nerfstudio-project#2867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-processing support for cache_images. Now caching image is way more faster.
(Kind of messed up with branches and comments, the only changed file is full_images_datamanager.py. Please bear with me.)