Properly reset train state after render lock in viewer #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
reviewed
Oct 17, 2024
| self.viewer.get_model().train() | ||
| raise | ||
| self.viewer.get_model().train() | ||
| if was_training: |
Collaborator
There was a problem hiding this comment.
we could do:
finally:
if was_training:
self.viewer.get_model().train()and reduce some duplication?
Collaborator
Author
There was a problem hiding this comment.
I don't think this is possible because of the re-raising behavior of the except? is it possible for the finally to run after raising another exception?
Collaborator
Author
There was a problem hiding this comment.
Oh interesting it actually is possible in python, just updated it
Collaborator
There was a problem hiding this comment.
oh interesting good point, TIL also!!
brentyi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some crashes in the viewer when the training state was set back to train(), instead of keeping the prior state of the model.