Fixes #19800: ModuleType import supports associating ModuleTypeProfile #19803
Conversation
Also includes an additional regression assertion.
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
| InterfaceTemplate, FrontPortTemplate, RearPortTemplate, ModuleBayTemplate, | ||
| ] | ||
| for model in additional_permissions: | ||
| obj_perm.object_types.add(ObjectType.objects.get_for_model(model)) |
There was a problem hiding this comment.
Open to suggestions on this approach.
There was a problem hiding this comment.
There's an add_permissions() method on the test case to facilitate this; will that work?
| InterfaceTemplate, FrontPortTemplate, RearPortTemplate, ModuleBayTemplate, | ||
| ] | ||
| for model in additional_permissions: | ||
| obj_perm.object_types.add(ObjectType.objects.get_for_model(model)) |
There was a problem hiding this comment.
There's an add_permissions() method on the test case to facilitate this; will that work?
| fan_module_type = ModuleType.objects.get(part_number='generic-fan') | ||
| fan_module_type_profile = ModuleTypeProfile.objects.get(name='Fan') | ||
|
|
||
| assert fan_module_type.profile == fan_module_type_profile |
There was a problem hiding this comment.
I don't think this is needed. The test should be checking that each declared field was set to the correct value on import.
There was a problem hiding this comment.
Copy, will verify. My memory was that it was just checking object count relative to pre-test.
| @@ -471,7 +471,7 @@ class Meta: | |||
| model = ModuleType | |||
| fields = [ | |||
| 'manufacturer', 'model', 'part_number', 'description', 'airflow', 'weight', 'weight_unit', 'comments', | |||
| 'tags', | |||
| 'tags', 'profile', | |||
There was a problem hiding this comment.
Could you move profile before comments in the list? It affects the ordering of the fields in the import form.
Fixes: #19800
profileto the list of fields the import form should recognizeBulkImportObjectsViewTestCase