Skip to content

Closes #19589: Background job for bulk operations #19804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2025

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Jul 2, 2025

Closes: #19589

  • Introduce AsyncViewJob to handle the background execution of arbitrary views
  • Introduce the apply_request_processors() utility context manager for applying request processors
  • Extend BulkImportView to support execution via a background job
  • Add the background_job checkbox to BulkImportForm
  • The string representation of a job now shows its name (rather than its task ID)

@jeremystretch jeremystretch marked this pull request as ready for review July 3, 2025 18:27
@jeremystretch jeremystretch requested a review from jnovinger July 3, 2025 18:27
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremystretch , quick question, should a background import via pasted CSV (or via DataSource) also return a URL that points to the items modified by the request, e.g. http://127.0.0.1:8000/ipam/services/?modified_by_request=<request_id>? Or should that only be happening on the non-background job imports?

Apologies if I missed you describing that behavior before.

@jeremystretch
Copy link
Member Author

I'm not sure it makes sense for background jobs to redirect to the filtered view because it's typically going to show no results (because the job hasn't completed yet). On the other hand, it allows the user to easily refresh the page to check for results without having to click through the notification.

@jnovinger
Copy link
Member

I'm not sure it makes sense for background jobs to redirect to the filtered view because it's typically going to show no results (because the job hasn't completed yet). On the other hand, it allows the user to easily refresh the page to check for results without having to click through the notification.

That works for me, I just wanted to make sure I had the right expectation.

@jnovinger jnovinger merged commit 875a641 into feature Jul 10, 2025
6 checks passed
@jeremystretch jeremystretch deleted the 19589-bulk-import-jobs branch July 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants