Skip to content

Closes #19739: Add a user preference for CSV delimiter in table exports #19824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Closes #19739: Add a user preference for CSV delimiter in table exports #19824

merged 2 commits into from
Jul 8, 2025

Conversation

jeremystretch
Copy link
Member

Closes: #19739

  • Introduce the csv_delimiter user preference
  • Subclass TableExport from django-tables2 to support custom delimiters
  • Extend ObjectListView to infer delimiter from user preference during export

@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team July 7, 2025 17:36
jnovinger
jnovinger requested changes Jul 7, 2025
View reviewed changes
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom delimiters are not working for 'Export -> All Data (CSV)'.

@jeremystretch jeremystretch requested a review from jnovinger July 8, 2025 13:44
@jnovinger jnovinger merged commit 90e8a61 into feature Jul 8, 2025
6 checks passed
@jnovinger jnovinger deleted the 19739-csv-delimiter-pref branch July 8, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnovinger jnovinger jnovinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @jnovinger