Correctly handle onboarding exception when no device type is guessed #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Looks good!
FYI the one Travis failure appears to be due to Poetry's parallel installation feature - you may wish to disable that, as in nautobot/nautobot#52.
| @@ -178,7 +176,12 @@ def guess_netmiko_device_type(self): | |||
| logger.error("ERROR: %s", str(err)) | |||
| raise OnboardException(reason="fail-general", message=f"ERROR: {str(err)}") | |||
|
|
|||
| logger.info("INFO device type is: %s", guessed_device_type) | |||
| else: | |||
There was a problem hiding this comment.
I don't think the else: is needed here per se, but it's probably harmless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error handling for situations where occasionally Netmiko library does return
Noneobject for well-known device types.