Add support for default status #45
Conversation
netbox_onboarding/onboard.py
Outdated
| device = Device.objects.get( | ||
| name=self.netdev.hostname, | ||
| device_type=self.device_type, | ||
| device_role=self.netdev.ot.role, |
There was a problem hiding this comment.
Would it make sense to move device_type and device_role out of the get() call (so we match the device based only on name and site), and possibly update them even if we have an existing device? I'm thinking something like:
try:
device = Device.objects.get(name=self.netdev.hostname, site=self.netdev.ot.site)
except Device.DoesNotExist:
device = Device.objects.create(name=self.netdev.hostname, site=self.netdev.ot.site, status=default_status)
device.device_type = self.device_type
device.device_role = self.netdev.ot.role
device.platform = self.netdev.ot.platform
device.serial = self.netdev.serial_number
device.save()There was a problem hiding this comment.
@glennmatthews thanks, I think it's a great idea
I remove device_role and device_type from the get() but I couldn't remove them from create() because both are mandatory.
Now if a device already exist but doesn't have a platform, it will be updated as part of the onboarding as well as the serial number.
| self.assertIsInstance(nbk.device, Device) | ||
| self.assertEqual(nbk.device.status, "planned") | ||
| self.assertEqual(nbk.device, nbk.netdev.ot.created_device) | ||
| self.assertEqual(nbk.device.serial, "123456") |
There was a problem hiding this comment.
If you accept my previous comment, then it'd make sense to check nbk.device.device_role, nbk.device.device_type, nbk.device.platform here as well.
fixes #23