Skip to content

Add DNS Based OnBoarding #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2020
Merged

Add DNS Based OnBoarding #57

merged 8 commits into from
Jul 9, 2020

Conversation

jvanderaa
Copy link
Contributor

@jvanderaa jvanderaa commented Jul 1, 2020 •
edited
Loading

  • Completes a Name resolution using socket when the field entered is a name
  • Will still fail if name resolution does not work
  • Adds Django tests
  • Updates readme
  • Updates form

Fixes #43

@jvanderaa jvanderaa requested a review from dgarros July 1, 2020 19:31
glennmatthews
glennmatthews reviewed Jul 1, 2020
View reviewed changes
@jvanderaa jvanderaa requested a review from glennmatthews July 1, 2020 20:52
jvanderaa
jvanderaa commented Jul 7, 2020
View reviewed changes
jvanderaa
jvanderaa commented Jul 7, 2020
View reviewed changes
glennmatthews
glennmatthews approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue to address, otherwise looks good!

@jvanderaa jvanderaa requested a review from glennmatthews July 8, 2020 21:56
dgarros
dgarros reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jvanderaa, please update the read and we're good
thanks

netbox_onboarding/__init__.py
@@ -38,6 +38,7 @@ class OnboardingConfig(PluginConfig):
"default_management_interface": "PLACEHOLDER",
"default_management_prefix_length": 0,
"default_device_status": "active",
"create_management_interface_if_missing": True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you document this option in the README

@dgarros dgarros merged commit a31dde7 into networktocode:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarros dgarros dgarros left review comments

@glennmatthews glennmatthews Awaiting requested review from glennmatthews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow onboards by FQDN and not just IP
3 participants
@jvanderaa @dgarros @glennmatthews