This repository was archived by the owner on Jun 3, 2025. It is now read-only.
ModelAnalysis.create(...)
#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created: a base to make analyze api args + options importable Updated: `sparsezoo.analyze` cli to use the new importable `analyze_options`
… longer ignored by noqa: F811
* Conform CLI with arg requirements from [PRD](https://docs.google.com/document/d/1ys6FZjcv7cnQL1tVeSditG1IJMnd7dCGMXbfNHlwn-I/edit#heading=h.bpbwnw1mba1c) * Add impose arg
rahul-tuli
changed the title
ModelAnalysis.create(...)
Add tests for creation Migrate `sparsezoo.analyze` to use `.create`
rahul-tuli
force-pushed
the
analyze-compare-functionality
branch
2 times, most recently
from
6f1ed80 to
6567cc7
Compare
bfineran
previously approved these changes
Mar 21, 2023
…ionality # Conflicts: # src/sparsezoo/analyze/analysis.py # src/sparsezoo/analyze_cli.py
Merge: Main Address: Review Comments
8 tasks
bfineran
previously approved these changes
Mar 22, 2023
dbogunowicz
approved these changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.create(...)function forModelAnalysis, this makes it slightly easier to runModelAnalysison a variety of input:All of the above can now be used to create a ModelAnalysis, for example:
Before this PR doing the same as above would require a cumbersome
if-elseladder + error handling. that had the potential to be duplicated all across the codebase; this change now promotes one-source of truth for managing supported inputs