This repository was archived by the owner on Jun 3, 2025. It is now read-only.
fix return type annotation and tests #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekk-nm
approved these changes
Mar 22, 2023
tdg5
approved these changes
Apr 12, 2023
horheynm
pushed a commit
that referenced
this pull request
Apr 13, 2023
Co-authored-by: Danny Guinther <[email protected]>
horheynm
pushed a commit
that referenced
this pull request
Apr 17, 2023
* fix return type annotation and tests (#282) Co-authored-by: Danny Guinther <[email protected]> * error handling - send message from graphql (#286) * error handling - send message from graphql Union to Optional error message * error message * comments * tests * tests * change def name * error logic * Stub v2 (#271) * Dummy graphql requests module * graphql api request * return Model instances * Update NOTICE (#242) license name change * bump main to 1.4.0 (#246) Co-authored-by: dhuang <[email protected]> * Pin numpy version to <=1.21.6 (#247) search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download * lint * pass tests * init files * lint * Add dummy test using test-specific subclass * tests * add incremeent_downloads=False * allow empty arguments * comments * query parser, allow dict as input, add tests for extra functionality * restore models.utils * restore models.utils * v2 stub * comments * change stubs to ones on prod * lint * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <[email protected]> * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <[email protected]> * Update src/sparsezoo/api/utils.py Co-authored-by: Danny Guinther <[email protected]> --------- Co-authored-by: Danny Guinther <[email protected]> Co-authored-by: Jeannie Finks <[email protected]> Co-authored-by: dhuangnm <[email protected]> Co-authored-by: dhuang <[email protected]> Co-authored-by: Rahul Tuli <[email protected]> Co-authored-by: Danny Guinther <[email protected]> --------- Co-authored-by: Danny Guinther <[email protected]> Co-authored-by: Danny Guinther <[email protected]> Co-authored-by: Jeannie Finks <[email protected]> Co-authored-by: dhuangnm <[email protected]> Co-authored-by: dhuang <[email protected]> Co-authored-by: Rahul Tuli <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1201735099598282/1204220468331631
and edit graphql tests