This repository was archived by the owner on Jun 3, 2025. It is now read-only.
fix type #283
Merged
fix type #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekk-nm
reviewed
Mar 22, 2023
|
It would be useful to have some tests here that verify this change is working correctly. |
There already are tests to check both List and Dict. |
tdg5
previously approved these changes
Mar 22, 2023
derekk-nm
reviewed
Mar 23, 2023
derekk-nm
previously approved these changes
Mar 23, 2023
tdg5
reviewed
Mar 23, 2023
tdg5
previously approved these changes
Mar 23, 2023
Co-authored-by: Danny Guinther <[email protected]>
tdg5
approved these changes
Mar 23, 2023
derekk-nm
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.