Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

[analytics] disable in make test and GHA tests, unit test to always check send_event #293

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[analytics] disable in make test and GHA tests, unit test to always check send_event #293

merged 2 commits into from
Apr 12, 2023

Conversation

bfineran
Copy link
Contributor

@bfineran bfineran commented Apr 5, 2023 •
edited
Loading

adds env var to disable analytics calls in GHA tests and make test

adds unit test to override the disable and verify a simple send_event call. add pathway to ensure that analytics thread completes

test_plan:

  • unit tests included
  • @markurtz to verify GHA no longer triggers GA calls

@bfineran bfineran requested review from markurtz and mgoin April 5, 2023 20:20
@bfineran bfineran self-assigned this Apr 5, 2023
rahul-tuli
rahul-tuli approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

@bfineran bfineran merged commit a9718cc into main Apr 12, 2023
@bfineran bfineran deleted the analytics-testing branch April 12, 2023 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markurtz markurtz Awaiting requested review from markurtz

2 more reviewers

@mgoin mgoin mgoin approved these changes

@rahul-tuli rahul-tuli rahul-tuli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bfineran bfineran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bfineran @mgoin @rahul-tuli