Skip to content

fix(adapter): transistion to surrealdb@^1.0.0 #11911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

dvanmali
Copy link

☕️ Reasoning

Moves package dependency to version 1 of the surrealdb javascript library. Package includes websocket connectivity, type safety, updates to the setup documentation, and package peer dependency change.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

#11732 - solves this by transistioning to [email protected] package. Docs state to use new connection string.
#11866 - javascript package supports surrealdb v2
#11471 - uses current surrealdb software

📌 Resources

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Mar 14, 2025 8:16pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2025 8:16pm

Copy link

vercel bot commented Sep 26, 2024

@dvanmali is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters surrealdb labels Sep 26, 2024
@dvanmali dvanmali mentioned this pull request Sep 26, 2024
3 tasks
@dvanmali dvanmali changed the title Transition to surrealdb@^1.0.0 feat(adapter): transistion to surrealdb@^1.0.0 Sep 26, 2024
@dvanmali dvanmali changed the title feat(adapter): transistion to surrealdb@^1.0.0 fix(adapter): transistion to surrealdb@^1.0.0 Sep 26, 2024
@liamwh
Copy link
Contributor

liamwh commented Oct 7, 2024

Any updates on this PR? Would love to see it merged so we can use SurrealDB with Auth.js!

@dvanmali
Copy link
Author

dvanmali commented Oct 9, 2024

Any updates on this PR? Would love to see it merged so we can use SurrealDB with Auth.js!

Package is ready to go. Still waiting for PR to merge.

@ubbe-xyz @ndom91

@applied-mathematician
Copy link

Bump. I'm waiting for this PR to use Auth.js since I'm using Surrealdb.

@ndom91
Copy link
Member

ndom91 commented Nov 9, 2024

This is breaking, right? Well have to make sure we bump the surreal adapter appropriately

@dvanmali
Copy link
Author

ndom91 This is breaking, right? Well have to make sure we bump the surreal adapter appropriately

Yes, this is a breaking update because the underlying storage layer and transmission layer are now both typed. Thus this package jumps to version 2.0.0 with surrealdb@^1.0.0

@ctison
Copy link

ctison commented Dec 7, 2024

Surreal Cloud just launched! I am planning to use it everywhere I can. Do you know what is blocking this PR?

@Padi2312
Copy link

Padi2312 commented Feb 7, 2025

Is this PR still up-to-date ? Looking forward to use SurrealDB and AuthJS together but with surrealdb v2 it doesnt work anymore.

@dvanmali
Copy link
Author

dvanmali commented Feb 7, 2025

Is this PR still up-to-date ? Looking forward to use SurrealDB and AuthJS together but with surrealdb v2 it doesnt work anymore.

Yes this PR should still work with v2, if you have issues let me know

@Padi2312
Copy link

Padi2312 commented Feb 7, 2025

@dvanmali sorry for my bad english, i ment whether this PR will ever get merged :D

I just copied your index.ts file and imported from local package, works perfectly fine. Thanks🫱🏼‍🫲🏽

@dvanmali
Copy link
Author

@ndom91 @0ubbe PR updates? It's been 5 months since opening

@tz-torchai
Copy link

tz-torchai commented May 4, 2025

Hi @ThangHuuVu ! 👋

Hope you are doing well!

Could you please help give a review and ship this PR?

This has been blocking for SurrealDB and Auth.js users for a while.

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters surrealdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants