Skip to content

Remove File Actions #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

Remove File Actions #1048

merged 4 commits into from
Apr 29, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Apr 16, 2025 •
edited
Loading

Proposed changes

Remove File Actions from Protos

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Apr 16, 2025
@aphralG aphralG requested a review from a team as a code owner April 16, 2025 08:45
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Apr 16, 2025
NutsaB
NutsaB reviewed Apr 17, 2025
View reviewed changes
internal/file/file_manager_service_test.go Outdated
Permissions: "",
Size: 0,
filesCache := map[string]*model.FileCache{
"File/path/test.conf": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"File/path/test.conf": {
"file/path/test.conf": {

@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 17, 2025
@aphralG aphralG merged commit 741357d into v3 Apr 29, 2025
20 checks passed
@aphralG aphralG deleted the remove-actions branch April 29, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

@john-david3 john-david3 john-david3 approved these changes

@NutsaB NutsaB NutsaB approved these changes

Assignees

@aphralG aphralG

Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aphralG @dhurley @craigell @sean-breen @john-david3 @NutsaB @oCHRISo