-
Notifications
You must be signed in to change notification settings - Fork 86
Fix Add OTel Receiver After Config Apply & Fix Reload Monitoring Old Log #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aphralG
merged 43 commits into
v3
from
dynamically-add-otel-receiver-after-config-apply
Apr 29, 2025
Merged
Fix Add OTel Receiver After Config Apply & Fix Reload Monitoring Old Log #1057
aphralG
merged 43 commits into
v3
from
dynamically-add-otel-receiver-after-config-apply
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-david3
approved these changes
Apr 25, 2025
dhurley
reviewed
Apr 28, 2025
sean-breen
approved these changes
Apr 29, 2025
dhurley
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes to Config Apply:
nginx_config_parser.go
frominternal/watcher/instance
to/internal/datasource/config
to allow the resource plugin to also have anNginxConfigParser
to parse the configNginxPlusRuntimeInfoEqual
,NginxRuntimeInfoEqual
&UpdateNginxInstanceRuntime
to/datasource/proto/instance.go
frominstance_watcher_service.go
so they can be used in theResourceService
as well as theInstanceWatcherService
ConfigApplySuccessfulTopic
now sendsConfigApplySuccess
which contains aNginxConfigContext
as well as aDataPlaneResponse
instead of just aDataPlaneResponse
Validating
andReloading
the config will now parse the NGINX config so it can have access to any error logs that might have been added to monitor. If the validate and reload are successful it sends theNginxConfigContext
created during the parse along withDataPlane Response
Other changes made:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)