Skip to content

Cleanup integration tests #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: v3
Choose a base branch
from
Open

Cleanup integration tests #1066

wants to merge 15 commits into from

Conversation

NutsaB
Copy link

@NutsaB NutsaB commented Apr 28, 2025

Proposed changes

  • Split up grpc_management_plane_api_test.go integration tests into multiple files for scalability.
  • Created config_apply_test.go config_apply_utils.go config_upload_test.go file_watcher_test.go grpc_management_plane_utils.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@NutsaB NutsaB self-assigned this Apr 28, 2025
@NutsaB NutsaB requested a review from a team as a code owner April 28, 2025 10:03
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-david3 john-david3 john-david3 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@NutsaB NutsaB

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NutsaB @john-david3