Skip to content

Add env variables for make dev target #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

john-david3
Copy link

Proposed changes

  • Added two environment variables to the make dev target
    • One for the manifest file directory path and the other for the collector config path
  • Created new default value for the manifest directory
  • Removed the manifest file path from file_manager_service.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@john-david3 john-david3 self-assigned this Apr 30, 2025
@john-david3 john-david3 requested a review from a team as a code owner April 30, 2025 13:07
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant