Skip to content

Refactor integration tests #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2025
Merged

Refactor integration tests #985

merged 6 commits into from
Feb 20, 2025

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Feb 14, 2025 •
edited
Loading

Proposed changes

  • Updated integration tests dependencies
  • Removed github.com/testcontainers/testcontainers-go/modules/compose dependency
  • Refactored integration tests by removing the need for docker compose

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Feb 14, 2025
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Feb 14, 2025
@dhurley dhurley changed the title Update integration tests dependencies Refactor integration tests Feb 19, 2025
@dhurley dhurley marked this pull request as ready for review February 19, 2025 09:13
@dhurley dhurley requested a review from a team as a code owner February 19, 2025 09:13
@dhurley dhurley removed the documentation Improvements or additions to documentation label Feb 19, 2025
@dhurley dhurley merged commit c3cef4a into main Feb 20, 2025
37 checks passed
@dhurley dhurley deleted the chore/update-int-test-deps branch February 20, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

@aphralG aphralG aphralG approved these changes

Assignees

@dhurley dhurley

Labels
chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhurley @craigell @sean-breen @aphralG