Fix installation of ingressclass resource via helm chart on certain kubernetes versions #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug first appeared in: d893dd0 Helm will fail to install the ingressclass resource when the patch value of the semver contains some non-numerical suffix. For example: * v1.18.8-rc.1 * v1.18.10-gke.601
lucacome
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Helm will fail to install the ingressclass resource when the patch value of the semver contains some non-numerical suffix.
For example:
Proposed changes
On kubernetes versions
v1.18.*-*(see examples above) the ingressclass resource is installed successfully:Checklist
Before creating a PR, run through this checklist and mark each as complete.