Support snippets in TransportServer #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
pleshakov
reviewed
Mar 19, 2021
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
@soneillf5
code looks good!
some comments on the docs
lucacome
approved these changes
Mar 19, 2021
soneillf5
force-pushed
the
feature-transportserver-stream-snippets
branch
from
92fd487 to
08201c8
Compare
pleshakov
approved these changes
Mar 22, 2021
lucacome
added
the
enhancement
soneillf5
force-pushed
the
feature-transportserver-stream-snippets
branch
from
08201c8 to
883eb5d
Compare
soneillf5
force-pushed
the
feature-transportserver-stream-snippets
branch
from
883eb5d to
6a25da7
Compare
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add stream level snippets to transport servers.
Checklist
Before creating a PR, run through this checklist and mark each as complete.