Skip to content

Add pod labels to helm chart #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2021
Merged

Add pod labels to helm chart #1884

merged 2 commits into from
Aug 23, 2021

Conversation

@soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Aug 19, 2021 •
edited
Loading

Proposed changes

This change adds the option of adding labels to the Ingress Controller pods.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@soneillf5 soneillf5 force-pushed the feature/helm-chart-pod-labels branch 2 times, most recently from 62b96d2 to fbe970b Compare August 19, 2021 11:52
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Aug 19, 2021
pleshakov
pleshakov reviewed Aug 19, 2021
View reviewed changes
@soneillf5 soneillf5 requested a review from ciarams87 August 20, 2021 08:27
@soneillf5 soneillf5 force-pushed the feature/helm-chart-pod-labels branch from 2dcc9a6 to b205bab Compare August 20, 2021 09:37
@soneillf5 soneillf5 force-pushed the feature/helm-chart-pod-labels branch from 2c192b4 to 5022602 Compare August 21, 2021 10:49
@soneillf5 soneillf5 merged commit 681556d into master Aug 23, 2021
@soneillf5 soneillf5 deleted the feature/helm-chart-pod-labels branch August 23, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

+1 more reviewer

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@soneillf5 @pleshakov @ciarams87 @nginx-bot