Skip to content

Conversation

@shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 25, 2023

Proposed changes

The below warning message was being thrown when an Ingress resource did not have an ingressClassName AND the annotation kubernetes.io/ingress.class was not used.

W1025 09:30:31.434146       1 controller.go:3985] Using the DEPRECATED annotation 'kubernetes.io/ingress.class'. The 'ingressClassName' field will be ignored.

This warning message should only be displayed when kubernetes.io/ingress.class is used AND ingressClassName is not used.

Testing: Confirmed warning message was absent when deploying an Ingress resource with both ingressClassName AND the annotation kubernetes.io/ingress.class missing. This same test was performed for the mergable ingress type (master -minion) to ensure configurations are applied correctly.

Resolves #4550

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner October 25, 2023 09:39
@github-actions github-actions bot added the bug An issue reporting a potential bug label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4564 (820f3b5) into main (7a1e600) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4564   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          59       59           
  Lines       16962    16962           
=======================================
  Hits         8816     8816           
  Misses       7849     7849           
  Partials      297      297           
Files Coverage Δ
internal/k8s/controller.go 11.93% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx merged commit 8a93be8 into main Nov 2, 2023
@shaun-nx shaun-nx deleted the fix/ing-class-warning branch November 2, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue reporting a potential bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NIC throws warnings re deprecated annotations when ingressClassName isn't used

4 participants