Skip to content

Conversation

@ADubhlaoich
Copy link
Member

@ADubhlaoich ADubhlaoich commented Nov 15, 2023

Proposed changes

This commit fixes Helm versioning issues in a document.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit fixes Helm versioning issues in a document.
@ADubhlaoich ADubhlaoich requested review from a team as code owners November 15, 2023 12:34
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 15, 2023
@codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0233436) 51.96% compared to head (82ca478) 51.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4654   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files          59       59           
  Lines       16960    16960           
=======================================
  Hits         8814     8814           
  Misses       7849     7849           
  Partials      297      297           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…r-secret.md

Co-authored-by: Venktesh Shivam Patel <[email protected]>
Signed-off-by: Alan Dooley <[email protected]>
@shaun-nx shaun-nx merged commit c7680a4 into main Nov 15, 2023
@shaun-nx shaun-nx deleted the additional-version-fixes branch November 15, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants