Cherry-pick NGINX App Protect WAF & VirtualServer documentation changes #4844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit rewrites the installation document for NGINX App Protect WAF to match the format posited in the prior NGINX App Protect DOS rewrite. As part of the changes, a snippet of text indicating the deployment options for NGINX Ingress Controller was turned into an include. This commit adds a new include file for custom resources, and subsequently adds it to the relevant App Protect WAF/DoS documentation. A few documentation improvements are also included to rephrase sections of the configuration document for conciseness and clarity.
This commit fixes a broken link in the VirtualServer tutorial for custom ports that was intended to point at the repository's example folder. While addressing this change, I also updated the other links to become relative references to avoid other issues.
👷 Deploy request for nginx-kubernetes-ingress accepted.
|
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.4 #4844 +/- ##
===============================================
- Coverage 52.03% 52.01% -0.03%
===============================================
Files 60 60
Lines 17313 17313
===============================================
- Hits 9009 9005 -4
- Misses 7993 7995 +2
- Partials 311 313 +2 ☔ View full report in Codecov by Sentry. |
vepatel
approved these changes
Dec 27, 2023
jjngx
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR cherry-picks two commits from the main branch: the first is a set of changes for the NGINX App Protect WAF integration and the other is to fix a broken link in a VirtualServer tutorial (And updating others at the same time).
Checklist
Before creating a PR, run through this checklist and mark each as complete.