Skip to content

Conversation

@shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Mar 12, 2024

Proposed changes

This change sets the GRPC endpoint that telemetry data will be sent to.

Additional changes:
The layout of the Helm arguments for telemetry have been changed.
We originally had enableTelemetryReporting as the only option.

This was done to future proof these settings.

controller:
  ## Configure telemetry reporting options
  telemetryReporting:
    ## Enable telemetry reporting
    enable: true

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Mar 12, 2024
@shaun-nx shaun-nx linked an issue Mar 12, 2024 that may be closed by this pull request
@shaun-nx shaun-nx requested a review from vepatel March 13, 2024 14:30
@shaun-nx shaun-nx marked this pull request as ready for review March 13, 2024 15:04
@shaun-nx shaun-nx requested review from a team as code owners March 13, 2024 15:04
@github-actions github-actions bot added the tests Pull requests that update tests label Mar 14, 2024
@shaun-nx shaun-nx changed the title Enable Telemetry Job to configure an endpoint for the exporter Update Telemetry Job with GRPC endpoint Mar 14, 2024
@shaun-nx shaun-nx requested a review from jjngx March 14, 2024 12:22
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @shaun-nx can we merge this PR after NIC Replicas?

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor changes.

@shaun-nx
Copy link
Contributor Author

@ADubhlaoich Thanks for the input.
I'm going to add those changes into another PR that I'm submitting today just in the interest of not re-running the pipeline.
I'll link you that same PR when it's up.

@shaun-nx shaun-nx merged commit 7f31dac into main Mar 14, 2024
@shaun-nx shaun-nx deleted the feat/telemetry-endpoint branch March 14, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Telemetry Job to configure an endpoint for the exporter

6 participants