Skip to content

Choose NodePort values for controller.service.type = LoadBalancer #5335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Choose NodePort values for controller.service.type = LoadBalancer #5335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4815d5
update doc for controller.service.httpsPort.nodePort
Apr 2, 2024
068831e
add possibility to choose nodePort port for LoadBalancer
Apr 2, 2024
ce807fe
Merge branch 'main' into main
Falltrades Apr 9, 2024
4bb9882
Merge branch 'main' into main
Falltrades Apr 23, 2024
495b829
Merge branch 'main' into main
vepatel Jul 18, 2024
7a9c92e
Merge branch 'main' into main
vepatel Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/nginx-ingress/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,11 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont
|`controller.service.customPorts` | A list of custom ports to expose through the Ingress Controller service. Follows the conventional Kubernetes yaml syntax for service ports. | [] |
|`controller.service.httpPort.enable` | Enables the HTTP port for the Ingress Controller service. | true |
|`controller.service.httpPort.port` | The HTTP port of the Ingress Controller service. | 80 |
|`controller.service.httpPort.nodePort` | The custom NodePort for the HTTP port. Requires `controller.service.type` set to `NodePort`. | "" |
|`controller.service.httpPort.nodePort` | The custom NodePort for the HTTP port. Requires `controller.service.type` set to `NodePort` or `LoadBalancer`. | "" |
|`controller.service.httpPort.targetPort` | The target port of the HTTP port of the Ingress Controller service. | 80 |
|`controller.service.httpsPort.enable` | Enables the HTTPS port for the Ingress Controller service. | true |
|`controller.service.httpsPort.port` | The HTTPS port of the Ingress Controller service. | 443 |
|`controller.service.httpsPort.nodePort` | The custom NodePort for the HTTPS port. Requires `controller.service.type` set to `NodePort`. | "" |
|`controller.service.httpsPort.nodePort` | The custom NodePort for the HTTPS port. Requires `controller.service.type` set to `NodePort` or `LoadBalancer`. | "" |
|`controller.service.httpsPort.targetPort` | The target port of the HTTPS port of the Ingress Controller service. | 443 |
|`controller.serviceAccount.annotations` | The annotations of the Ingress Controller service account. | {} |
|`controller.serviceAccount.name` | The name of the service account of the Ingress Controller pods. Used for RBAC. | Autogenerated |
Expand Down
4 changes: 2 additions & 2 deletions charts/nginx-ingress/templates/controller-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
targetPort: {{ .Values.controller.service.httpPort.targetPort }}
protocol: TCP
name: http
{{- if eq .Values.controller.service.type "NodePort" }}
{{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }}
nodePort: {{ .Values.controller.service.httpPort.nodePort }}
{{- end }}
{{- end }}
Expand All @@ -59,7 +59,7 @@ spec:
targetPort: {{ .Values.controller.service.httpsPort.targetPort }}
protocol: TCP
name: https
{{- if eq .Values.controller.service.type "NodePort" }}
{{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }}
nodePort: {{ .Values.controller.service.httpsPort.nodePort }}
{{- end }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions charts/nginx-ingress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ controller:
## The HTTP port of the Ingress Controller service.
port: 80

## The custom NodePort for the HTTP port. Requires controller.service.type set to NodePort.
## The custom NodePort for the HTTP port. Requires controller.service.type set to NodePort or LoadBalancer.
# nodePort: 80

## The HTTP port on the POD where the Ingress Controller service is running.
Expand All @@ -449,7 +449,7 @@ controller:
## The HTTPS port of the Ingress Controller service.
port: 443

## The custom NodePort for the HTTPS port. Requires controller.service.type set to NodePort.
## The custom NodePort for the HTTPS port. Requires controller.service.type set to NodePort or LoadBalancer.
# nodePort: 443

## The HTTPS port on the POD where the Ingress Controller service is running.
Expand Down