Skip to content

Test splitting smoke tests by dependency #5803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use label for report name
  • Loading branch information
oseoin committed Jun 20, 2024
commit d28c287c453efdc03fa08df9dab35dbd01445bac
14 changes: 9 additions & 5 deletions .github/actions/smoke-tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ inputs:
marker:
description: Marker to use
required: false
label:
description: Label for test
required: false
azure-ad-secret:
description: Azure Active Directory secret for JWKs
required: false
Expand All @@ -45,12 +48,13 @@ runs:
run: |
make -f tests/Makefile create-kind-cluster K8S_CLUSTER_NAME=${{ github.run_id }} K8S_CLUSTER_VERSION=${{ inputs.k8s-version }} K8S_TIMEOUT=${{ inputs.k8s-timeout }}
make -f tests/Makefile image-load REGISTRY="" PREFIX=${{ inputs.image-name }} TAG=${{ inputs.tag }} K8S_CLUSTER_NAME=${{ github.run_id }}
marker="${{ inputs.marker }}"
nospaces="${marker// /_}"
sanitized_marker="${nospaces//\'/}"
name="${sanitized_marker:-${{ inputs.k8s-version }}}"
label="${{ inputs.label }}"
nospaces="${label// /_}"
noslash="${nospaces//\//_}"
sanitized_marker="${noslash//\'/}"
name="${sanitized_marker}-${{ inputs.k8s-version }}"
cluster_ip=$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' ${{ github.run_id }}-control-plane)
test_name=tests-nginx-${{ inputs.image-type }}-$name.html
test_name=tests-nginx-${{ inputs.image-type }}-${name}.html
test_output_path=${{ github.workspace }}/tests/${test_name}
echo "cluster_ip=${cluster_ip}" >> $GITHUB_OUTPUT
echo "test_name=${test_name}" >> $GITHUB_OUTPUT
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,7 @@ jobs:
target: ${{ matrix.images.target }}
nap-modules: ${{ matrix.images.nap_modules }}
marker: ${{ matrix.images.marker }}
label: ${{ matrix.images.label }}
go-md5: ${{ needs.checks.outputs.go_code_md5 }}
build-tag: ${{ needs.checks.outputs.build_tag }}
stable-tag: ${{ needs.checks.outputs.stable_tag }}
Expand All @@ -686,6 +687,7 @@ jobs:
target: ${{ matrix.images.target }}
nap-modules: ${{ matrix.images.nap_modules }}
marker: ${{ matrix.images.marker }}
label: ${{ matrix.images.label }}
go-md5: ${{ needs.checks.outputs.go_code_md5 }}
build-tag: ${{ needs.checks.outputs.build_tag }}
stable-tag: ${{ needs.checks.outputs.stable_tag }}
Expand All @@ -712,6 +714,7 @@ jobs:
target: ${{ matrix.images.target }}
nap-modules: ${{ matrix.images.nap_modules }}
marker: ${{ matrix.images.marker }}
label: ${{ matrix.images.label }}
go-md5: ${{ needs.checks.outputs.go_code_md5 }}
build-tag: ${{ needs.checks.outputs.build_tag }}
stable-tag: ${{ needs.checks.outputs.stable_tag }}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/setup-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ on:
marker:
required: true
type: string
label:
required: true
type: string
go-md5:
required: true
type: string
Expand Down Expand Up @@ -150,6 +153,7 @@ jobs:
image-name: ${{ steps.image_details.outputs.name }}
tag: ${{ steps.image_details.outputs.build_tag }}
marker: ${{ inputs.marker != '' && inputs.marker || '' }}
label: ${{ inputs.label }}
k8s-version: ${{ inputs.k8s-version }}
azure-ad-secret: ${{ secrets.AZURE_AD_AUTOMATION }}
test-image: "gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/test-runner:${{ hashFiles('./tests/requirements.txt') || 'latest' }}"
Expand All @@ -158,6 +162,6 @@ jobs:
- name: Upload Test Results
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: ${{ steps.smoke-tests.outputs.test-results-name }}-${{ inputs.k8s-version }}
name: ${{ steps.smoke-tests.outputs.test-results-name }}
path: ${{ steps.smoke-tests.outputs.test-results-path }}
if: always()
Loading