Skip to content

move docs and fix go toolchain #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2024
Merged

move docs and fix go toolchain #6547

merged 2 commits into from
Oct 1, 2024

Conversation

@vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 1, 2024 •
edited
Loading

Proposed changes

  • Move NIM instructions to WAF v5 section,
  • Fix go toolchain error with hugo commands

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Oct 1, 2024
@vepatel vepatel requested review from a team as code owners October 1, 2024 09:47
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6547/

@vepatel vepatel merged commit db1022d into main Oct 1, 2024
@vepatel vepatel deleted the docs/move-bundle-page branch October 1, 2024 10:25
nginx-bot pushed a commit that referenced this pull request Oct 1, 2024
@vepatel @web-flow
move docs and fix go toolchain (#6547)
13c7da5
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changelog Pull requests that don't need to be added to the changelog

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vepatel @AlexFenlon @jjngx @pdabelf5