Skip to content

Symlink to central secret #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

Symlink to central secret #7038

merged 1 commit into from
Dec 20, 2024

Conversation

@nginx-bot
Copy link
Contributor

@nginx-bot nginx-bot commented Dec 20, 2024

Proposed changes

Update where possible to use centralised TLS secrets so they can be updated in one place

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner December 20, 2024 12:16
@nginx-bot nginx-bot added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch python Pull requests that update Python code tests Pull requests that update tests labels Dec 20, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) December 20, 2024 12:40
@pdabelf5 pdabelf5 linked an issue Dec 20, 2024 that may be closed by this pull request
[Bug]: Certs in example and test folders are expired #6433
Closed
1 task
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Dec 20, 2024
@pdabelf5 pdabelf5 merged commit a272f8a into release-4.0 Dec 20, 2024
70 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-c4f35e987a23b670daee084c254ef1cfe3ec9614 branch December 20, 2024 15:29
@pdabelf5 pdabelf5 removed documentation Pull requests/issues for documentation python Pull requests that update Python code labels Feb 6, 2025
@pdabelf5 pdabelf5 changed the title [cherry-pick] symlink to central secret Symlink to central secret Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests Pull requests that update tests

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Certs in example and test folders are expired

4 participants

@nginx-bot @jjngx @pdabelf5