Skip to content

GenerateVirtualServer upstreams config refactor #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2025
Merged

GenerateVirtualServer upstreams config refactor #7264

merged 8 commits into from
Jul 22, 2025

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 4, 2025 •
edited
Loading

Proposed changes

Pull common code into one function

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 4, 2025 13:51
@github-actions github-actions bot added the go Pull requests that update Go code label Feb 4, 2025
@codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (ab54158) to head (c3ea6f6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/virtualserver.go 81.03% 9 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7264      +/-   ##
==========================================
+ Coverage   52.99%   53.09%   +0.09%     
==========================================
  Files          90       90              
  Lines       21750    21770      +20     
==========================================
+ Hits        11527    11559      +32     
+ Misses       9746     9736      -10     
+ Partials      477      475       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jjngx
jjngx previously approved these changes Feb 4, 2025
View reviewed changes
AlexFenlon
AlexFenlon previously approved these changes Feb 4, 2025
View reviewed changes
@pdabelf5 pdabelf5 dismissed stale reviews from AlexFenlon and jjngx via 91a850b July 18, 2025 11:37
@pdabelf5 pdabelf5 force-pushed the vs-config-refactor branch from c2f9284 to 91a850b Compare July 18, 2025 11:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

Package Report

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx, 1.27.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-module-njs, 1.27.5+0.8.10-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-module-otel, 1.27.5+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 3.0.3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx, 1.27.5-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-module-njs, 1.27.5+0.8.10-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-module-otel, 1.27.5+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 3.0.3~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus, 34-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 3.0.3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus, 34-2~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-njs, 34+0.8.9-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-otel, 34+0.1.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-fips-check, 34+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 3.0.3~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus, 34-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect, 34+5.442.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-attack-signatures, 2025.07.17-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-threat-campaigns, 2025.07.16-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 2.42.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus, 34-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-module-plus, 34+5.442.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-plugin, 6.16.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 2.42.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus, 34-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-appprotectdos, 34+4.6.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-dos, 34+4.6.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus, 34-2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-njs, 34+0.8.9-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-otel, 34+0.1.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-fips-check, 34+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-appprotect, 34+5.442.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect, 34+5.442.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-attack-signatures, 2025.07.17-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-threat-campaigns, 2025.07.16-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-plus-module-appprotectdos, 34+4.6.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, app-protect-dos, 34+4.6.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a, nginx-agent, 2.42.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx, 1.27.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-module-njs, 1.27.5.0.8.10-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-module-otel, 1.27.5.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-agent, 3.0.3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx, 1.27.5-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-module-njs, 1.27.5.0.8.10-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-module-otel, 1.27.5.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-agent, 3.0.3, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus, 34-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus-module-njs, 34.0.8.9-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus-module-otel, 34.0.1.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus-module-fips-check, 34.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-agent, 3.0.3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus, 34-r2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus-module-njs, 34.0.8.9-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus-module-otel, 34.0.1.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-plus-module-fips-check, 34.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine, nginx-agent, 3.0.3, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus, 34-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-agent, 3.0.3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus, 34-r2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-agent, 3.0.3, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus, 34-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-agent, 2.42.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-appprotect, 34.5.442.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, app-protect, 34.5.442.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, app-protect-attack-signatures, 2025.07.17-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, app-protect-threat-campaigns, 2025.07.16-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus, 34-r2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-njs, 34.0.8.9-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-otel, 34.0.1.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-fips-check, 34.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-agent, 2.42.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, nginx-plus-module-appprotect, 34.5.442.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, app-protect-module-plus, 34.5.442.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-alpine-fips, app-protect-plugin, 6.16.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx, 1.27.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-module-njs, 1.27.5+0.9.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-module-otel, 1.27.5+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 3.0.3-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx, 1.27.5-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-module-njs, 1.27.5+0.9.0-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-module-otel, 1.27.5+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 3.0.3-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus, 34-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 3.0.3-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus, 34-2.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 3.0.3-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus, 34-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 2.42.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect, 34+5.442.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-attack-signatures, 2025.07.17-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-threat-campaigns, 2025.07.16-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus, 34-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 2.42.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-module-plus, 34+5.442.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-plugin, 6.16.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus, 34-2.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-njs, 34+0.8.9-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-otel, 34+0.1.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-fips-check, 34+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-agent, 2.42.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-appprotect, 34+5.442.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, app-protect, 34+5.442.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, app-protect-attack-signatures, 2025.07.17-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, app-protect-threat-campaigns, 2025.07.16-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus, 34-2.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-njs, 34+0.8.9-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-otel, 34+0.1.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-fips-check, 34+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-agent, 2.42.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, nginx-plus-module-appprotect, 34+5.442.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, app-protect-module-plus, 34+5.442.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi8, app-protect-plugin, 6.16.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus, 34-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-appprotectdos, 34+4.6.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-dos, 34+4.6.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus, 34-2.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-njs, 34+0.8.9-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-otel, 34+0.1.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-fips-check, 34+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-appprotect, 34+5.442.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-plus-module-appprotectdos, 34+4.6.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, nginx-agent, 2.42.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect, 34+5.442.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-attack-signatures, 2025.07.17-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-threat-campaigns, 2025.07.16-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-34b7757ce5f4eb7998a68670ae4aa58a-ubi, app-protect-dos, 34+4.6.1-1.el9.ngx, x86_64

AlexFenlon
AlexFenlon approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@AlexFenlon AlexFenlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@pdabelf5 pdabelf5 enabled auto-merge (squash) July 22, 2025 09:13
@pdabelf5 pdabelf5 merged commit e3e571d into main Jul 22, 2025
83 checks passed
@pdabelf5 pdabelf5 deleted the vs-config-refactor branch July 22, 2025 09:46
@github-project-automation github-project-automation bot moved this from Todo ☑ to Done 🚀 in NGINX Ingress Controller Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

+1 more reviewer

@jjngx jjngx jjngx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

go Pull requests that update Go code

Projects

NGINX Ingress Controller
Status: Done 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdabelf5 @vepatel @AlexFenlon @jjngx