Skip to content

tiered rate limit jwt e2e tests #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 3, 2025
Merged

tiered rate limit jwt e2e tests #7412

merged 23 commits into from
Mar 3, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 26, 2025

Proposed changes

  • small refactor of python test image
  • add pyjwt to python test image
  • make all nginx variables use underscores rather than hyphens in virtualserver.go
  • add tiered rate limit e2e python tests
    • VS level - test_speclevel_rl_policy_tiered_basic_premium_no_default_jwt_claim_sub
    • VS level - test_speclevel_rl_policy_tiered_basic_premium_with_default_jwt_claim_sub
    • VS level - test_routelevel_rl_policy_tiered_basic_premium_with_default_jwt_claim_sub
    • VS level - test_routelevel_rl_policy_tiered_basic_premium_no_default_jwt_claim_sub
    • VS level - test_rl_duplicate_default_policy_tiered_basic_premium_with_default_jwt_claim_sub
    • VSR level - test_rl_policy_jwt_claim_sub_vsr
    • VSR level - test_rl_policy_tiered_basic_premium_no_default_jwt_claim_sub_vsr
    • VSR level - test_rl_policy_tiered_basic_premium_with_default_jwt_claim_sub_vsr
    • VSR level - test_rl_policy_multiple_tiered_jwt_claim_sub_vsr
    • VSR level - test_override_multiple_tiered_jwt_claim_sub_vs_vsr
    • VSR level - test_rl_duplicate_default_policy_tiered_basic_premium_with_default_jwt_claim_sub_vsr

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 26, 2025 16:04
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code docker Pull requests that update Docker code labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (9a0a3f7) to head (9703c6c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7412      +/-   ##
==========================================
- Coverage   52.76%   52.74%   -0.02%     
==========================================
  Files          89       89              
  Lines       21267    21267              
==========================================
- Hits        11221    11217       -4     
- Misses       9582     9584       +2     
- Partials      464      466       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 changed the title tiered rate limit jwt. e2e tests tiered rate limit jwt e2e tests Feb 27, 2025
@github-actions github-actions bot added chore Pull requests for routine tasks and removed chore Pull requests for routine tasks labels Feb 27, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 27, 2025
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Feb 28, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 28, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) March 3, 2025 10:03
@pdabelf5 pdabelf5 merged commit 8c5cc8d into main Mar 3, 2025
30 checks passed
@pdabelf5 pdabelf5 deleted the rate-limit-tests branch March 3, 2025 10:46
@pdabelf5 pdabelf5 added tests Pull requests that update tests and removed go Pull requests that update Go code python Pull requests that update Python code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants