Skip to content

Conversation

@AlexFenlon
Copy link
Contributor

Proposed changes

Update to #7737

Renames Agent Deployment metadata to match the requirements for N1C

  • DeploymentID/DeploymentName/DeploymentNamespace -> InstallationID/InstallationName/InstallationNamespace
  • ProductName -> ProductType
  • Change _ to -

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 22, 2025 09:22
@AlexFenlon AlexFenlon changed the title Rename Agent Deployment metadata to match the requirements Rename Agent Deployment metadata to match N1C requirements May 22, 2025
@github-actions github-actions bot added the go Pull requests that update Go code label May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.29%. Comparing base (f78b761) to head (9753a16).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 6 Missing ⚠️
...nternal/common_cluster_info/common_cluster_info.go 0.00% 1 Missing ⚠️
internal/metadata/metadata.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7827   +/-   ##
=======================================
  Coverage   52.29%   52.29%           
=======================================
  Files          90       90           
  Lines       21472    21472           
=======================================
  Hits        11228    11228           
  Misses       9774     9774           
  Partials      470      470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vepatel
vepatel previously approved these changes May 22, 2025
Co-authored-by: Venktesh Shivam Patel <[email protected]>
Signed-off-by: AlexFenlon <[email protected]>
@AlexFenlon AlexFenlon enabled auto-merge (squash) May 23, 2025 08:10
@AlexFenlon AlexFenlon merged commit 92a1d97 into main May 23, 2025
83 checks passed
@AlexFenlon AlexFenlon deleted the chore/update-metadata-names branch May 23, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants