Skip to content

Design for Technical Solutions for NGINX Customization #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mpstefan opened this issue Jul 5, 2023 · 4 comments
Closed

Design for Technical Solutions for NGINX Customization #815

mpstefan opened this issue Jul 5, 2023 · 4 comments
Assignees
@pleshakov
Labels
refined Requirements are refined and the issue is ready to be implemented. spike Issue to investigate a problem or solution, but not implement.
Milestone
v1.4.0

Comments

@mpstefan
Copy link
Member

mpstefan commented Jul 5, 2023 •
edited
Loading

Before pursuing a specific solution like NGINX Template Customization, we want to do a technical spike to investigate what solutions could be employed to allow users to customize NGINX behavior.

At the end of the spike, we want to determine:

  1. What solutions can be used to customize which behaviors?
  2. How much complexity and time will the solutions cost?
  3. What are the implications for security?
  4. What are the implications for support, when available?

The results of this investigation should be added to the provisional enhancement proposal for NGINX Customization.

Notes from our meetup on extensibility requirements are available here.

The answers to the above questions should be posted in the discussion here.
@mpstefan mpstefan added this to the v1.0.0 milestone Jul 5, 2023
@mpstefan mpstefan mentioned this issue Jul 5, 2023
Closed
@mpstefan mpstefan modified the milestones: v1.0.0, v0.6.0 Jul 12, 2023
@pleshakov
Copy link
Contributor

pleshakov commented Jul 26, 2023 •
edited
Loading

simple propotype -- https://github.com/pleshakov/nginx-kubernetes-gateway/tree/feature/custom-template

@mpstefan
Copy link
Member Author

mpstefan commented Aug 7, 2023

Application Delivery Manager and Ingress has template customization that we may use to leverage work in this spike.

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. spike Issue to investigate a problem or solution, but not implement. size/small Estimated to be completed within ~2 days labels Aug 7, 2023
@mpstefan mpstefan modified the milestones: v0.6.0, v1.0.1 Aug 23, 2023
@mpstefan
Copy link
Member Author

Take a look at #929 after this spike is complete.

@mpstefan mpstefan modified the milestones: v1.0.1, v1.1.0 Sep 26, 2023
@mpstefan mpstefan modified the milestones: v1.1.0, v1.2.0 Oct 23, 2023
@mpstefan mpstefan modified the milestones: v1.2.0, v1.3.0 Dec 11, 2023
@mpstefan mpstefan removed refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Mar 18, 2024
@mpstefan mpstefan changed the title [SPIKE] Investigate Technical Solution for NGINX Template Customization [SPIKE] Investigate Technical Solutions for NGINX Customization Apr 29, 2024
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Apr 29, 2024
@mpstefan mpstefan modified the milestones: v1.3.0, v1.4.0 May 14, 2024
@mpstefan mpstefan changed the title [SPIKE] Investigate Technical Solutions for NGINX Customization Design for Technical Solutions for NGINX Customization Jun 3, 2024
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Jul 3, 2024
@pleshakov
Move Advanced NGINX Extensions proposal to Implementable
b42ac6b 
Problem:
- Advanced NGINX Extensions proposal nginx#2035
  is in Provisional state - only problem statement is defined.

Solution:
- Add the implementation details to the proposal.
- Move the enhancement proposal to Implementable

Notes:
- The goal of Allowing users to customize supported NGINX configuration
  was moved to a Non-Goal to keep the size of the proposal manageable.
- This enhancement proposal can be further split into two - one for
  SnippetsPolicy and one for SnippetsTemplates

CLOSES - nginx#815
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Jul 3, 2024
@pleshakov
Move Advanced NGINX Extensions proposal to Implementable
42ed86a 
Problem:
- Advanced NGINX Extensions proposal nginx#2035
  is in Provisional state - only problem statement is defined.

Solution:
- Add the implementation details to the proposal.
- Move the enhancement proposal to Implementable

Notes:
- The goal of Allowing users to customize supported NGINX configuration
  was moved to a Non-Goal to keep the size of the proposal manageable.
- This enhancement proposal can be further split into two - one for
  SnippetsPolicy and one for SnippetsTemplates

CLOSES - nginx#815
@pleshakov pleshakov mentioned this issue Jul 3, 2024
Merged
6 tasks
pleshakov added a commit that referenced this issue Jul 18, 2024
@pleshakov
Move Advanced NGINX Extensions proposal to Implementable (#2201)
e8e494f 
Problem:
- Advanced NGINX Extensions proposal #2035
  is in Provisional state - only problem statement is defined.

Solution:
- Add the implementation details to the proposal.
- Move the enhancement proposal to Implementable

Notes:
- The goal of Allowing users to customize supported NGINX configuration
  was moved to a Non-Goal to keep the size of the proposal manageable.
- This enhancement proposal can be further split into two - one for
  SnippetsPolicy/SnippetsFilter and one for SnippetsTemplates

CLOSES - #815
@sjberman
Copy link
Collaborator

Closed by #2201

miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Move Advanced NGINX Extensions proposal to Implementable (nginx#2201)
1f619c7 
Problem:
- Advanced NGINX Extensions proposal nginx#2035
  is in Provisional state - only problem statement is defined.

Solution:
- Add the implementation details to the proposal.
- Move the enhancement proposal to Implementable

Notes:
- The goal of Allowing users to customize supported NGINX configuration
  was moved to a Non-Goal to keep the size of the proposal manageable.
- This enhancement proposal can be further split into two - one for
  SnippetsPolicy/SnippetsFilter and one for SnippetsTemplates

CLOSES - nginx#815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
refined Requirements are refined and the issue is ready to be implemented. spike Issue to investigate a problem or solution, but not implement.
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
3 participants
@pleshakov @mpstefan @sjberman