Skip to content

Implement Status Updater Retrying on Failures #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 27, 2023
Merged

Implement Status Updater Retrying on Failures #1062

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8a12ef7
Add retrying logic
bjee19 Sep 11, 2023
3700daf
WIP
bjee19 Sep 20, 2023
1b12225
Use imported retry function and address review feedback
bjee19 Sep 21, 2023
977e594
Delete unused fake client
bjee19 Sep 21, 2023
c66f3e5
Add back deleted documentation
bjee19 Sep 21, 2023
c1f7bc3
Move comments around
bjee19 Sep 21, 2023
1fdb2a3
Fix renaming mistake
bjee19 Sep 21, 2023
5922b7e
Switch to using ToNot instead of ShouldNot
bjee19 Sep 21, 2023
2d17d36
Remove unnecessary goroutines
bjee19 Sep 21, 2023
b1fcff1
Remove lastError and add debug level logs
bjee19 Sep 22, 2023
eab8773
Add error to debug message
bjee19 Sep 22, 2023
936ca4c
WIP
bjee19 Sep 26, 2023
c62b364
Add testing for ConditionWithContextFunc
bjee19 Sep 26, 2023
c304fa2
Change naming and add subtests
bjee19 Sep 26, 2023
1149c6f
Add review feedback
bjee19 Sep 27, 2023
4ee28e9
Add small comment fix
bjee19 Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix renaming mistake
  • Loading branch information
@bjee19
bjee19 committed Sep 26, 2023
commit 1fdb2a3d1261886938204d5631e72a26f347b652
4 changes: 2 additions & 2 deletions internal/framework/status/updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ type UpdaterConfig struct {
// Gateway is removed, our Gateway will not restore the status until the EventLoop invokes the StatusUpdater as a
// result of processing some other new change to a resource(s).
// FIXME(pleshakov): Make updater production ready
// https://github.com/nginxinc/nginx-kubernetes-gateway/issues/691
// https://github.com/nginxinc/nginx-gateway-fabric/issues/691

// UpdaterImpl needs to be modified to support new resources. Consider making UpdaterImpl extendable, so that it
// goes along the Open-closed principle.
Expand Down Expand Up @@ -127,7 +127,7 @@ func NewUpdater(cfg UpdaterConfig) *UpdaterImpl {

func (upd *UpdaterImpl) Update(ctx context.Context, status Status) {
// FIXME(pleshakov) Merge the new Conditions in the status with the existing Conditions
// https://github.com/nginxinc/nginx-kubernetes-gateway/issues/558
// https://github.com/nginxinc/nginx-gateway-fabric/issues/558

defer upd.lock.Unlock()
upd.lock.Lock()
Expand Down