Use single timeout for reload retries #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjberman
approved these changes
Oct 11, 2023
kate-osborn
suggested changes
Oct 11, 2023
pleshakov
reviewed
Oct 11, 2023
kate-osborn
approved these changes
Oct 12, 2023
ciarams87
force-pushed
the
fix/increase-worker-timeout
branch
from
ada0861 to
7a95c9f
Compare
pleshakov
approved these changes
Oct 12, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
* Use single context for reload retries * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NGF doesn't wait long enough for new NGINX workers to start
Solution: Expand the whole reload timeout to cover both waiting for the new worker processes and waiting for the workers to start serving the new configuration.
Testing: Unit testing
Closes #1106
Checklist
Before creating a PR, run through this checklist and mark each as complete.