Skip to content

Set SupportedVersion on GatewayClass #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 5, 2023
Merged

Set SupportedVersion on GatewayClass #1301

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9e056ef
Add SupportedVersion condition
Nov 29, 2023
b340ebb
Update release process doc
Nov 30, 2023
974f503
ShouldNot -> ToNot; code review
Dec 1, 2023
1b34ab1
Add panic for GVK
Dec 1, 2023
7a544ba
Add comments and change RecommendedVersion -> SupportedVersion
Dec 1, 2023
5128763
Name return args
Dec 1, 2023
fc6c68c
Change from map to list
Dec 1, 2023
75499db
Remove trackUpsertDelete comment
Dec 1, 2023
b9bc464
Style suggestions
Dec 4, 2023
32bc60d
Add back in comment about relationship capturer
Dec 4, 2023
8b45826
Change predicate name
Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Name return args
  • Loading branch information
Kate Osborn committed Dec 5, 2023
commit 512876344ef974e04255f6ff3a72582471990a89
2 changes: 1 addition & 1 deletion internal/framework/gatewayclass/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type apiVersion struct {

func ValidateCRDVersions(
crdMetadata map[types.NamespacedName]*metav1.PartialObjectMetadata,
) ([]conditions.Condition, bool) {
) (conds []conditions.Condition, valid bool) {
installedAPIVersions := getBundleVersions(crdMetadata)
supportedAPIVersion := parseVersionString(SupportedVersion)

Expand Down